beliefer commented on a change in pull request #32107:
URL: https://github.com/apache/spark/pull/32107#discussion_r612088888
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -1110,6 +1112,14 @@ class DataFrameAggregateSuite extends QueryTest
val e =
intercept[AnalysisException](arrayDF.groupBy(struct($"col.a")).count())
assert(e.message.contains("requires integral type"))
}
+
+ test("SPARK-34716: Support ANSI SQL intervals by the aggregate function
`sum`") {
Review comment:
For your first suggestion. I think we should not add the negative tests.
Because we have the negative tests for `Add`. Sum(int), Sum(decimal) not add
the negative tests, because they depend the robust of `Add`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
