MaxGekk commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612134221
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in
"spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in
"spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
-Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly
*ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
Review comment:
Would be nice to put the example in one line. This would make life
easier, so, devs could just copy-past it.
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in
"spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in
"spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
-Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly
*ThriftServerQueryTestSuite"
Review comment:
Should we specify hive: `-Phive` or `-Phive-2.3`? I usually do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
