MaxGekk commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612162964
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in
"spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in
"spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
-Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly
*ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
Review comment:
```diff
diff --git
a/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
b/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
index dd008f738e..2cee97f31e 100644
---
a/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
+++
b/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
@@ -33,6 +33,7 @@ import
org.apache.spark.sql.execution.HiveResult.{getTimeFormatters, toHiveStrin
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
+// scalastyle:off line.size.limit
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
@@ -45,12 +46,17 @@ import org.apache.spark.sql.types._
* {{{
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly
*SQLQueryTestSuite"
* }}}
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly
*ThriftServerQueryTestSuite -- -z inline-table.sql"
+ * }}}
*
* TODO:
* 1. Support UDF testing.
* 2. Support DESC command.
* 3. Support SHOW command.
*/
+// scalastyle:on line.size.limit
class ThriftServerQueryTestSuite extends SQLQueryTestSuite with
SharedThriftServer {
```
```
$ ./dev/scalastyle
Scalastyle checks passed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
