Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5741#discussion_r29333490
--- Diff: core/src/main/scala/org/apache/spark/util/AkkaUtils.scala ---
@@ -30,6 +32,48 @@ import org.apache.log4j.{Level, Logger}
import org.apache.spark.{Logging, SecurityManager, SparkConf, SparkEnv,
SparkException}
/**
+ * Binds a timeout to a configuration property so that a thrown akka
timeout exception can be
+ * traced back to the originating value. The main constructor takes a
generic timeout and
+ * description while the auxilary constructor uses a specific property
defined in the
+ * configuration.
+ * @param timeout_duration timeout duration in milliseconds
+ * @param timeout_description description to be displayed in a timeout
exception
+ */
+class ConfiguredTimeout(timeout_duration: FiniteDuration,
timeout_description: String = null) {
--- End diff --
scala convention is camelCase, so `timeoutDuration` and
`timeoutDescription`. But in this case, I think `timeout` is a little
redundant anyway, so maybe just `duration` and `description`. I don't think
you should have a `null` default for `description`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
