cloud-fan commented on a change in pull request #31913:
URL: https://github.com/apache/spark/pull/31913#discussion_r612562805
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregatesSuite.scala
##########
@@ -96,7 +96,7 @@ class RemoveRedundantAggregatesSuite extends PlanTest {
.groupBy('a + 'b)(('a + 'b) as 'c)
.analyze
val optimized = Optimize.execute(query)
- comparePlans(optimized, expected)
+ comparePlans(optimized, EnforceGroupingReferencesInAggregates(expected))
Review comment:
hmm, the `Optimize` in this test doesn't include the new rule
`EnforceGroupingReferencesInAggregates`, why would the `optimzed` plan contains
grouping refs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
