[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32149: [SPARK-28227][SQL][FOLLOWUP] Add test case about transform expression with `distinct`

Tue, 13 Apr 2021 19:29:55 -0700 


AngersZhuuuu commented on a change in pull request #32149:
URL: https://github.com/apache/spark/pull/32149#discussion_r612894887



##########
File path: sql/core/src/test/resources/sql-tests/results/transform.sql.out
##########
@@ -638,3 +639,15 @@ struct<b:string>
 1
 2
 3
+
+
+-- !query
+SELECT TRANSFORM(distinct b, a, c)

Review comment:
       > BTW why do we support `TRANSFORM(a as b)`? is it from Hive? Normal 
function parameters can't have alias.
   
   Hive not support this. 
   
   
![image](https://user-images.githubusercontent.com/46485123/114645556-4a7ff400-9d0c-11eb-91eb-bc679ea0039a.png)
   
   may be we should not use 
   ```
   namedExpressionSeq
       : namedExpression (',' namedExpression)*
       ;
   
   (SELECT kind=TRANSFORM '(' namedExpressionSeq ')'
               | kind=MAP namedExpressionSeq
               | kind=REDUCE namedExpressionSeq)
   ```
   
   maybe 
   ```
   expressionSeq 
       : expression(',' expression) 
       ;
   
   (SELECT kind=TRANSFORM '(' expressionSeq ')'
               | kind=MAP expressionSeq
               | kind=REDUCE eExpressionSeq)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to