ulysses-you commented on a change in pull request #32084: URL: https://github.com/apache/spark/pull/32084#discussion_r613123229
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/UnionAwareOptimizerRule.scala ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.adaptive + +import org.apache.spark.sql.execution.{SparkPlan, UnionExec} + +trait UnionAwareOptimizerRule { Review comment: Thank you for the input. Actual the rule(child) does not consider the children of the Union, as it just try to optimize the plan. For the nested Union. Here are two case, the first is ok if we skip the check but the second can be optimized through every Union that will cause the repetitiion. ``` Union HashAggregate ShuffleQueryStage Union HashAggregate ShuffleQueryStage FileScan ``` ``` Union HashAggregate ShuffleQueryStage Union HashAggregate ShuffleQueryStage HashAggregate ShuffleQueryStage ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
