Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5685#discussion_r29344970
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1627,7 +1627,10 @@ class SparkContext(config: SparkConf) extends
Logging with ExecutorAllocationCli
partitions: Seq[Int],
allowLocal: Boolean
): Array[U] = {
- runJob(rdd, (context: TaskContext, iter: Iterator[T]) => func(iter),
partitions, allowLocal)
+ // We must clean `func` here before using it in another closure below
+ // Otherwise, the closure cleaner will only clean the outer closure
but not `func`
+ val cleanedFunc = clean(func)
--- End diff --
Do we need to apply such fix to other places? E.g., RDD.scala
```Scala
def mapPartitions[U: ClassTag](
f: Iterator[T] => Iterator[U], preservesPartitioning: Boolean =
false): RDD[U] = {
val func = (context: TaskContext, index: Int, iter: Iterator[T]) =>
f(iter)
new MapPartitionsRDD(this, sc.clean(func), preservesPartitioning)
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
