Github user ilganeli commented on the pull request:
https://github.com/apache/spark/pull/5636#issuecomment-97494755
Imran - I believe they would get the Exception since the call to abortStage
throws a SparkException. I believe I can check for that to confirm the end to
end behavior.
Sent with Good (www.good.com)
-----Original Message-----
From: Imran Rashid
[[email protected]<mailto:[email protected]>]
Sent: Wednesday, April 29, 2015 02:35 AM Eastern Standard Time
To: apache/spark
Cc: Ganelin, Ilya
Subject: Re: [spark] [SPARK-5945] Spark should not retry a stage infinitely
on a FetchFailedException (#5636)
Thanks for the update @ilganeli<https://github.com/ilganeli> ! my comments
are mostly minor. The only thing which is bugging me is that the tests don't
really show how the stage failure gets pushed up to the user code. Eg., do they
get a SparkException with a good message -- or does the DAGScheduler end up in
some weird state where it stops running any additional jobs? I think it should
work, but the DAGScheduler code is hairy enough that I'd really prefer a test.
But I can't come up with a good way to write a unit test (or test manually for
that matter). Maybe something like this test in ShuffleSuite?
https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/ShuffleSuite.scala#L264
The problem is you don't have a good way to delete the shuffle files
between stage attempts ... but maybe we could swap-in a different
diskBlockManager that always fails to find the files or something. I'll think
about it a little more.
â
Reply to this email directly or view it on
GitHub<https://github.com/apache/spark/pull/5636#issuecomment-97323086>.
________________________________________________________
The information contained in this e-mail is confidential and/or proprietary
to Capital One and/or its affiliates. The information transmitted herewith is
intended only for use by the individual or entity to which it is addressed. If
the reader of this message is not the intended recipient, you are hereby
notified that any review, retransmission, dissemination, distribution, copying
or other use of, or taking of any action in reliance upon this information is
strictly prohibited. If you have received this communication in error, please
contact the sender and delete the material from your computer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
