dongjoon-hyun commented on a change in pull request #32147:
URL: https://github.com/apache/spark/pull/32147#discussion_r613755701
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
##########
@@ -73,7 +73,12 @@ private[sql] class JacksonGenerator(
private val gen = {
val generator = new
JsonFactory().createGenerator(writer).setRootValueSeparator(null)
- if (options.pretty) generator.useDefaultPrettyPrinter() else generator
+ val ppGenerator = if (options.pretty) generator.useDefaultPrettyPrinter()
else generator
+ if (options.writeNonAsciiCharacterAsCodePoint) {
+ generator.setHighestNonEscapedChar(0x7F)
Review comment:
This code means that we cannot set both `options.pretty` and
`options.writeNonAsciiCharacterAsCodePoint`. If this is true, shall we document
it somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
