gengliangwang commented on a change in pull request #32157:
URL: https://github.com/apache/spark/pull/32157#discussion_r613798048
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
##########
@@ -231,6 +234,15 @@ case class Alias(child: Expression, name: String)(
copy(child = newChild)(exprId, qualifier, explicitMetadata,
nonInheritableMetadataKeys)
}
+// Singleton tree pattern BitSet for all AttributeReference instances.
+object AttributeReferenceTreeBits {
+ val bits: BitSet = {
+ val bits: BitSet = new BitSet(TreePattern.maxId)
+ bits.set(ATTRIBUTE_REFERENCE.id)
+ bits
Review comment:
Do we consider having a new class for immutable BitSet to avoid the
singleton bits being modified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
