sigmod commented on a change in pull request #32157:
URL: https://github.com/apache/spark/pull/32157#discussion_r614568602
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -307,6 +335,14 @@ case class Literal (value: Any, dataType: DataType)
extends LeafExpression {
private def timeZoneId =
DateTimeUtils.getZoneId(SQLConf.get.sessionLocalTimeZone)
+ protected override def getDefaultTreePatternBits: BitSet = {
Review comment:
Done.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
##########
@@ -253,6 +265,8 @@ case class AttributeReference(
val qualifier: Seq[String] = Seq.empty[String])
extends Attribute with Unevaluable {
+ protected override def getDefaultTreePatternBits: BitSet =
AttributeReferenceTreeBits.bits
Review comment:
Done.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreePatterns.scala
##########
@@ -23,8 +23,12 @@ object TreePattern extends Enumeration {
// Enum Ids start from 0.
// Expression patterns (alphabetically ordered)
- val EXPRESSION_WITH_RANDOM_SEED = Value(0)
+ val ATTRIBUTE_REFERENCE = Value(0)
+ val EXPRESSION_WITH_RANDOM_SEED = Value
val IN: Value = Value
+ val LITERAL: Value = Value
+ val NULL: Value = Value
Review comment:
Done.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreePatterns.scala
##########
@@ -23,8 +23,12 @@ object TreePattern extends Enumeration {
// Enum Ids start from 0.
// Expression patterns (alphabetically ordered)
- val EXPRESSION_WITH_RANDOM_SEED = Value(0)
+ val ATTRIBUTE_REFERENCE = Value(0)
+ val EXPRESSION_WITH_RANDOM_SEED = Value
val IN: Value = Value
+ val LITERAL: Value = Value
+ val NULL: Value = Value
+ val TRUE_OR_FALSE: Value = Value
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
