MaxGekk commented on a change in pull request #32203:
URL: https://github.com/apache/spark/pull/32203#discussion_r614599155
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
##########
@@ -73,7 +74,7 @@ private[sql] class JacksonGenerator(
private val gen = {
val generator = new
JsonFactory().createGenerator(writer).setRootValueSeparator(null)
- if (options.pretty) generator.useDefaultPrettyPrinter() else generator
Review comment:
`useDefaultPrettyPrinter()` should return the same default printer, see
the method's doc:
```
/**
* Convenience method for enabling pretty-printing using
* the default pretty printer
* ({@link com.fasterxml.jackson.core.util.DefaultPrettyPrinter}).
*
* @return This generator, to allow call chaining
*/
public abstract JsonGenerator useDefaultPrettyPrinter();
```
Could you clarify how your code changes the behavior, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
