sunchao commented on a change in pull request #32082: URL: https://github.com/apache/spark/pull/32082#discussion_r615067938
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/V2Aggregator.scala ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions.aggregate + +import java.io.{ByteArrayInputStream, ByteArrayOutputStream, ObjectInputStream, ObjectOutputStream} + +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions.Expression +import org.apache.spark.sql.connector.catalog.functions.{AggregateFunction => V2AggregateFunction} +import org.apache.spark.sql.types.DataType + +case class V2Aggregator[BUF <: java.io.Serializable, OUT]( + aggrFunc: V2AggregateFunction[BUF, OUT], + children: Seq[Expression], + mutableAggBufferOffset: Int = 0, + inputAggBufferOffset: Int = 0) extends TypedImperativeAggregate[BUF] { + override def createAggregationBuffer(): BUF = aggrFunc.newAggregationState() + + override def update(buffer: BUF, input: InternalRow): BUF = aggrFunc.update(buffer, input) Review comment: @cloud-fan I checked the magic method support for aggregate functions and there are a few issues: 1. seems we can't reuse the existing `Invoke` as the `invokeUpdate` method will also take aggregate state `BUF` as input, while `Invoke` evaluates on `InternalRow` only. 2. only hash aggregation support codegen at the moment and also it doesn't support `ImperativeAggregate`. Do you mind we leave this as a TODO for now and handle it separately? I think it requires some work to implement this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
