zhangrenhua commented on a change in pull request #32222:
URL: https://github.com/apache/spark/pull/32222#discussion_r615369897
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
##########
@@ -301,10 +306,44 @@ private[jdbc] class JDBCRDD(
ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY)
stmt.setFetchSize(options.fetchSize)
stmt.setQueryTimeout(options.queryTimeout)
- rs = stmt.executeQuery()
+
+ val isFinished = new AtomicBoolean(false)
+ startTheJobInterruptListenerThread(context, stmt, isFinished)
+ try{
+ rs = stmt.executeQuery()
+ } finally {
+ isFinished.set(true)
+ }
val rowsIterator = JdbcUtils.resultSetToSparkInternalRows(rs, schema,
inputMetrics)
CompletionIterator[InternalRow, Iterator[InternalRow]](
new InterruptibleIterator(context, rowsIterator), close())
}
+
+ /**
+ * Start the job interruption listener thread, if the job is interrupted and
+ * stmt.executeQuery() is not completed, initiate a stmt.cancel() request.
+ */
+ private def startTheJobInterruptListenerThread(context: TaskContext, stmt:
PreparedStatement
+ , isFinished: AtomicBoolean):
Unit = {
+ val thread = new Thread(() => {
+ val waitInterval = 100
Review comment:
I have no way of knowing how long the sql execution needs to be
processed. It may be a few seconds or a few hours, so I use the default 100
milliseconds to see if the job is interrupted/the query is completed. Do you
mean that you need to parameterize this variable for configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
