Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5580#discussion_r29373594
  
    --- Diff: project/SparkBuild.scala ---
    @@ -361,12 +361,20 @@ object PySparkAssembly {
         // to be included in the assembly. We can't just add "python/" to the 
assembly's resource dir
         // list since that will copy unneeded / unwanted files.
         resourceGenerators in Compile <+= resourceManaged in Compile map { 
outDir: File =>
    +      val src = new File(BuildCommons.sparkHome, "python/pyspark")
    +
    +      val zipFile = new File(BuildCommons.sparkHome , 
"python/lib/pyspark.zip")
    +      IO.delete(zipFile)
    +      def entries(f: File):List[File] =
    +        f :: (if (f.isDirectory) 
IO.listFiles(f).toList.flatMap(entries(_)) else Nil)
    +      IO.zip(entries(src).map(
    --- End diff --
    
    Could you use the usual style here?
    
        .map { foo => code }
    
    The indendation is also a little funny (`zipFile` looks like an argument to 
`map` when it's not).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to