GitHub user andrewor14 opened a pull request:

    https://github.com/apache/spark/pull/5787

    [SPARK-7237] Many user provided closures are not actually cleaned

    Note: ~110 lines are tests.
    
    In a nutshell, we never cleaned closures provided through the following 
operations:
    - sortBy
    - keyBy
    - mapPartitions
    - mapPartitionsWithIndex
    - aggregateByKey
    - foldByKey
    - foreachAsync
    - one of the aliases for runJob
    
    For more details on a reproduction and why they were not cleaned, please 
see [SPARK-7237](https://issues.apache.org/jira/browse/SPARK-7237).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andrewor14/spark clean-more

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5787.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5787
    
----
commit 19e33b4f6e3e8534fa6f7b63de458a0ee11b14d6
Author: Andrew Or <[email protected]>
Date:   2015-04-29T19:42:38Z

    Add tests for all public RDD APIs that take in closures
    
    Tests should fail as of this commit because the issue hasn't been
    fixed yet.

commit 9ac5f9b818713f8a7699f44994e4dbab2ebc9dba
Author: Andrew Or <[email protected]>
Date:   2015-04-29T19:51:23Z

    Clean closures that are not currently cleaned
    
    Now the test added in the previous commit passes!

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to