FatalLin commented on pull request #32202: URL: https://github.com/apache/spark/pull/32202#issuecomment-822019164
> @FatalLin > Some more thoughts/question: > > 1. Why are two configs in Hive for this? > > * mapred.input.dir.recursive > * hive.mapred.supports.subdirectories > > 1. How does Hive do when only one is true? If there both needed we need to check both too! > 2. Please update the title: skip the part "when configuration is enable" and reword the rest. > What about "Supporting non-partitioned Hive tables with subdirectories". > 3. Please update the description, too. In "What changes were proposed in this pull request?" its enough if you explain the the title a bit more. I suggest to use a spell checker to avoid errors like: setted => set, configurtions => configuration. > Please note the PR description is extremely important as after the PR is merged it will be the commit message. > 4. At "Does this PR introduce any user-facing change?" elaborate on the impact of this change. Remove the "maybe we could add this option in documents to notice users for the enhancement." which I think is a good idea and should be part of this PR. got it, it's a great help for me, really appreciated! I'll address all the questions you mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
