viirya commented on a change in pull request #32221:
URL: https://github.com/apache/spark/pull/32221#discussion_r615426803
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SparkReadinessWatcher.scala
##########
@@ -30,12 +30,12 @@ private[spark] class SparkReadinessWatcher[T <:
HasMetadata] extends Watcher[T]
override def eventReceived(action: Action, resource: T): Unit = {
if ((action == Action.MODIFIED || action == Action.ADDED) &&
- Readiness.isReady(resource)) {
+ Readiness.getInstance().isReady(resource)) {
Review comment:
do we need to pull `Readiness.getInstance()` as private variable? Is it
cheap to call `Readiness.getInstance()` every call of `eventReceived`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
