dongjoon-hyun commented on a change in pull request #32221:
URL: https://github.com/apache/spark/pull/32221#discussion_r615452336
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsWatchSnapshotSource.scala
##########
@@ -58,10 +58,14 @@ private[spark] class ExecutorPodsWatchSnapshotSource(
snapshotsStore.updatePod(pod)
}
- override def onClose(e: KubernetesClientException): Unit = {
+ override def onClose(e: WatcherException): Unit = {
logWarning("Kubernetes client has been closed (this is expected if the
application is" +
Review comment:
Although `expected` was there, the message doesn't mean that `Exception
will happen always`. Instead, it means you may see `Exception` some cases. In
this context of `onClose`, `WatcherException` already happened. So,
`logWarning` says the users that this exception is not **unexpected** one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
