[GitHub] [spark] HyukjinKwon commented on a change in pull request #32235: [SPARK-35120][INFRA] Guide users to sync branch and enable GitHub Actions in their forked repository

Mon, 19 Apr 2021 05:39:46 -0700 


HyukjinKwon commented on a change in pull request #32235:
URL: https://github.com/apache/spark/pull/32235#discussion_r615810453



##########
File path: .github/workflows/notify_test_workflow.yml
##########
@@ -57,34 +57,63 @@ jobs:
             await new Promise(r => setTimeout(r, 3000))
 
             const runs = await github.request(endpoint, params)
-            const runID = runs.data.workflow_runs[0].id
-            // TODO: If no workflows were found, it's likely GitHub Actions 
was not enabled
-
-            if (runs.data.workflow_runs[0].head_sha != 
context.payload.pull_request.head.sha) {
-              throw new Error('There was a new unsynced commit pushed. Please 
retrigger the workflow.');
-            }
-
-            const runUrl = 'https://github.com/'
-              + context.payload.pull_request.head.repo.full_name
-              + '/actions/runs/'
-              + runID
 
             const name = 'Build and test'
             const head_sha = context.payload.pull_request.head.sha
-            const status = 'queued'
+            let status = 'queued'
+
+            if (runs.data.workflow_runs.length === 0) {

Review comment:
       ![Screen Shot 2021-04-19 at 9 25 32 
PM](https://user-images.githubusercontent.com/6477701/115237507-9c36dd00-a157-11eb-8ba7-f5f88caa1058.png)
   ![Screen Shot 2021-04-19 at 9 23 13 
PM](https://user-images.githubusercontent.com/6477701/115237519-9e993700-a157-11eb-97de-4beae1d9bc41.png)
   

##########
File path: .github/workflows/update_build_status.yml
##########
@@ -74,7 +74,8 @@ jobs:
                           check_run_id: cr.id,
                           output: cr.output,
                           status: run.data.status,
-                          conclusion: run.data.conclusion
+                          conclusion: run.data.conclusion,
+                          details_url: run.data.details_url

Review comment:
       It links "View more details on GitHub Actions" to the workflow run in 
forked repository:
   ![Screen Shot 2021-04-19 at 9 16 26 
PM](https://user-images.githubusercontent.com/6477701/115237290-5da12280-a157-11eb-8d6b-91c90d0dace2.png)
   
   This is an unrelated minor change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to