tgravescs commented on a change in pull request #31974:
URL: https://github.com/apache/spark/pull/31974#discussion_r615880200
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -1353,4 +1363,22 @@ private[spark] class AppStatusListener(
}
}
+ /**
+ *
+ * @param processInfoEvent Miscellaneous Process Info Event
Review comment:
I think this is pretty obvious so unless we are adding more useful
description just remove the scala doc here
##########
File path: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala
##########
@@ -227,6 +227,10 @@ case class SparkListenerUnschedulableTaskSetRemoved(
@DeveloperApi
case class SparkListenerBlockUpdated(blockUpdatedInfo: BlockUpdatedInfo)
extends SparkListenerEvent
+@DeveloperApi
+case class MiscellaneousProcessAdded(time: Long, processId: String,
Review comment:
I just realized we should name this
SparkListenerMiscellaneousProcessAdded to differentiate from the cluster
message, which we should call MiscellaneousProcessAdded
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedClusterMessage.scala
##########
@@ -124,6 +124,11 @@ private[spark] object CoarseGrainedClusterMessages {
case class RegisterClusterManager(am: RpcEndpointRef) extends
CoarseGrainedClusterMessage
+ // Send Miscellaneous Process information to the driver
+ case class MiscellaneousProcessInfo(
Review comment:
call MiscellaneousProcessAdded
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/MiscellaneousProcessDetails.scala
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.scheduler
+
+import org.apache.spark.annotation.DeveloperApi
+
+/**
+ * :: DeveloperApi ::
+ * Stores information about an Miscellaneous Process to pass from the
scheduler to SparkListeners.
+ */
+
+@DeveloperApi
+class MiscellaneousProcessDetails(
+ val hostPort: String,
+ val cores: Int,
+ val memory: Long,
Review comment:
like I mentioned in other comment remove memory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
