dongjoon-hyun commented on pull request #32226: URL: https://github.com/apache/spark/pull/32226#issuecomment-822531897
Thank you for your review and approval, @viirya . @attilapiros . I fully agree with you technically because I also don't use it, but I want to be careful here and want to make no surprise to all users because this is very old behavior from the initial K8s support. In terms of the release management, in general, for non-correctness behavior changes, we had better provide a fallback for one or two releases. After one or two releases, we can remove this config later and will be no-op safely. In addition, this removal of driver service is not an urgent bug either although this is a production issue in some environments. WDYT? > I am thinking about the advantage of keeping the driver service (if there is any) after the app terminates. > Because if we come up with some then we have to mention it in the "Does this PR introduce any user-facing change?" section as those are lost by this change. If there is none we can remove "spark.kubernetes.driver.service.deleteOnTermination" flag. > > The logs can be still accessed as we get those from the PODs which are still available. The UI already stopped as the app stopped, right? Then what could be lost by removing the service? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
