gengliangwang commented on a change in pull request #31451:
URL: https://github.com/apache/spark/pull/31451#discussion_r616379743
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala
##########
@@ -199,7 +202,37 @@ class SQLAppStatusListener(
}
private def aggregateMetrics(exec: LiveExecutionData): Map[Long, String] = {
- val metricTypes = exec.metrics.map { m => (m.accumulatorId, m.metricType)
}.toMap
+ val accumIds = exec.metrics.map(_.accumulatorId).toSet
+
+ val metricAggregationMap = new mutable.HashMap[String, (Array[Long],
Array[Long]) => String]()
+ val metricAggregationMethods = exec.metrics.map { m =>
+ val optClassName = CustomMetrics.parseV2CustomMetricType(m.metricType)
+ val metricAggMethod = optClassName.map { className =>
+ if (metricAggregationMap.contains(className)) {
+ metricAggregationMap(className)
+ } else {
+ // Try to initiate custom metric object
+ try {
+ val metric = Utils.loadExtensions(classOf[CustomMetric],
Seq(className), conf).head
+ val method =
+ (metrics: Array[Long], _: Array[Long]) =>
metric.aggregateTaskMetrics(metrics)
+ metricAggregationMap.put(className, method)
+ method
+ } catch {
+ case NonFatal(_) =>
+ // Cannot initiaize custom metric object, we might be in history
server that does
Review comment:
Nit: initialize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
