c21 commented on a change in pull request #32242:
URL: https://github.com/apache/spark/pull/32242#discussion_r616405930
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -761,8 +804,10 @@ case class HashAggregateExec(
val bufferTerm = ctx.freshName("aggBuffer")
val outputFunc = generateResultFunction(ctx)
+ val limitNotReachedCondition = limitNotReachedCond
Review comment:
Adding the limit early termination for first level map as well. This is
needed to fix test failure `SQLMetricsSuite.SPARK-25497: LIMIT within whole
stage codegen should not consume all the inputs` in
https://github.com/c21/spark/runs/2386397792?check_suite_focus=true. And this
is good to have anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
