Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5785#discussion_r29385039
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala
---
@@ -315,6 +315,30 @@ class RowMatrix(
}
/**
+ * Computes the inverse matrix using SVD
+ * @return a DenseMatrix
+ */
+ def computeInverse(): DenseMatrix = {
+ val nCoef = X.numCols.toInt
--- End diff --
The indentation and whitespace is off throughout this function, and I think
one line won't pass style checks for its length. This is minor though.
The bigger concern I have is, where do we need an inverse versus solving a
system? and the SVD is not always the best way to do it, etc. That is I don't
know how much we go down this road of trying to expose another whole library
for matrix ops.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
