gengliangwang commented on a change in pull request #32260:
URL: https://github.com/apache/spark/pull/32260#discussion_r617273921
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -404,6 +404,9 @@ trait DivModLike extends BinaryArithmetic {
protected def decimalToDataTypeCodeGen(decimalResult: String): String =
decimalResult
+ // Whether we should check overflow or not in ANSI mode.
+ protected def checkDivideOverflow: Boolean = false
Review comment:
No, Remainder's left can be Long as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
