Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5760#discussion_r29388845
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -370,9 +370,11 @@ private[spark] class Client(
try {
hadoopConfStream.setLevel(0)
hadoopConfFiles.foreach { case (name, file) =>
- hadoopConfStream.putNextEntry(new ZipEntry(name))
- Files.copy(file, hadoopConfStream)
- hadoopConfStream.closeEntry()
+ if(file.canRead()) {
--- End diff --
OK, yeah I see that in the docs, though it's not set up that way in CDH (at
least, maybe my installation never needed to configure that file a certain way,
dunno). It seems bad to silently ignore unreadable files, so at least log it
maybe? then... should it be a warning? because it sounds like there's one file
that could reasonably be expected to be unreadable. Do we special case it and
warn on anything else? fail on anything else? i'd rather tighten this up in
some way from doing this silently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
