LuciferYang commented on a change in pull request #32232:
URL: https://github.com/apache/spark/pull/32232#discussion_r618069694
##########
File path:
core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
def nextPartition(): Int
}
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it:
Iterator[((Int, K), V)])
Review comment:
turn the trait into the class will fail MiMa tests:
```
[error] spark-core: Failed binary compatibility check against
org.apache.spark:spark-core_2.12:3.0.0! Found 1 potential problems (filtered
1184)
[error] * declaration of interface
org.apache.spark.util.collection.WritablePartitionedIterator is class
org.apache.spark.util.collection.WritablePartitionedIterator in current
version; changing interface to class breaks client code
[error] filter with:
ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.util.collection.WritablePartitionedIterator")
```
Can you give me some guidance on how to solve this problem? @Ngone51
@HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
