dongjoon-hyun commented on a change in pull request #31876:
URL: https://github.com/apache/spark/pull/31876#discussion_r618075192



##########
File path: 
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -297,22 +298,25 @@ final class ShuffleBlockFetcherIterator(
 
     val fallback = FallbackStorage.FALLBACK_BLOCK_MANAGER_ID.executorId
     for ((address, blockInfos) <- blocksByAddress) {
-      if (Seq(blockManager.blockManagerId.executorId, 
fallback).contains(address.executorId)) {
+      // TODO (wuyi): For HDFS-like filesytem, shuffle fetch should be always 
considered as

Review comment:
       Please use IDed TODO like `TODO(SPARK-XXX)` instead of person id because 
it's a community code base.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to