mridulm commented on a change in pull request #32287:
URL: https://github.com/apache/spark/pull/32287#discussion_r618766753
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/util/NettyUtils.java
##########
@@ -37,6 +37,14 @@
*/
public class NettyUtils {
+ /**
+ * A flag which indicates whether the Netty OOM error has raised during
shuffle.
+ * If true, unless there's no in-flight fetch requests, all the pending
shuffle
+ * fetch requests will be deferred until the flag is unset (whenever there's
a
+ * complete fetch request).
+ */
+ public static volatile boolean isNettyOOMOnShuffle = false;
Review comment:
It is easier to reason about state transitions for `AtomicBoolean`,
while there are subtleties with `volatile`. Unless there are very good reasons,
I tend to use the former. Ofcourse, I marked it a "super nit" for that exact
reason :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
