Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/5589#discussion_r29396464
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -518,6 +518,9 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
_taskScheduler.postStartHook()
_env.metricsSystem.registerSource(new DAGSchedulerSource(dagScheduler))
_env.metricsSystem.registerSource(new
BlockManagerSource(_env.blockManager))
+ _executorAllocationManager.foreach { e =>
--- End diff --
Hi @sryza , thanks a lot for your comments. The reason I put this metric
source into `ExecutorAllocationManager` is that I don't want to change
`ExecutorAllocationManager` a lot to expose the internal status to metric
source, so I just wrote this metric source as the inner class. Do you have
specific concern about this implementation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
