viirya commented on a change in pull request #32338:
URL: https://github.com/apache/spark/pull/32338#discussion_r619867408
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeWithFieldsSuite.scala
##########
@@ -126,4 +126,25 @@ class OptimizeWithFieldsSuite extends PlanTest {
comparePlans(optimized, correctAnswer)
}
}
+
+ test("SPARK-35213: ensure optimize WithFields maintains correct struct
ordering") {
+ val originalQuery = testRelation
+ .select(
+ Alias(UpdateFields('a,
+ WithField("a1", Literal(3)) ::
+ WithField("b1", Literal(4)) ::
+ WithField("a1", Literal(5)) ::
+ Nil), "out")())
+
+ val optimized = Optimize.execute(originalQuery.analyze)
+ val correctAnswer = testRelation
+ .select(
+ Alias(UpdateFields('a,
+ WithField("a1", Literal(5)) ::
+ WithField("b1", Literal(4)) ::
+ Nil), "out")())
+ .analyze
+
+ comparePlans(optimized, correctAnswer)
+ }
Review comment:
If you check the output data type, you can see the struct type is not
different:
```
optimized: ArrayBuffer(StructType(StructField(a1,IntegerType,false),
StructField(b1,IntegerType,false)))
correctAnswer: ArrayBuffer(StructType(StructField(a1,IntegerType,false),
StructField(b1,IntegerType,false)))
```
By design, `UpdateFields` will keep the order of fields in struct expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
