otterc commented on a change in pull request #32287:
URL: https://github.com/apache/spark/pull/32287#discussion_r619993131
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -613,6 +618,12 @@ final class ShuffleBlockFetcherIterator(
}
if (isNetworkReqDone) {
reqsInFlight -= 1
+ if (!buf.isInstanceOf[NettyManagedBuffer]) {
+ // Non-`NettyManagedBuffer` doesn't occupy Netty's memory so we
can unset the flag
+ // directly once the request succeeds. But for the
`NettyManagedBuffer`, we'll only
+ // unset the flag when the data is fully consumed (see
`BufferReleasingInputStream`).
+ NettyUtils.isNettyOOMOnShuffle = false
Review comment:
My concern here is that in this case, an iterator checks if it is not a
`NettyManagedBuffer` and then doesn't wait to release the buffer and unsets the
flag. But what if another instance which has set
`NettyUtils.isNettyOOMOnShuffle=true` because it saw netty OOM and it can
recover only when nettyManagedBuffers are released?
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -613,6 +618,12 @@ final class ShuffleBlockFetcherIterator(
}
if (isNetworkReqDone) {
reqsInFlight -= 1
+ if (!buf.isInstanceOf[NettyManagedBuffer]) {
+ // Non-`NettyManagedBuffer` doesn't occupy Netty's memory so we
can unset the flag
+ // directly once the request succeeds. But for the
`NettyManagedBuffer`, we'll only
+ // unset the flag when the data is fully consumed (see
`BufferReleasingInputStream`).
+ NettyUtils.isNettyOOMOnShuffle = false
Review comment:
My concern here is that in this case, an iterator checks if it is not a
`NettyManagedBuffer` and then doesn't wait to release the buffer and unsets the
flag. But what if another instance which has set
`NettyUtils.isNettyOOMOnShuffle=true` because it saw netty OOM and it can send
more remote requests only when nettyManagedBuffers are released?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
