viirya commented on a change in pull request #31398:
URL: https://github.com/apache/spark/pull/31398#discussion_r619993990
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/CustomMetrics.scala
##########
@@ -47,25 +47,21 @@ object CustomMetrics {
}
/**
- * Built-in `CustomMetric` that sums up metric values.
+ * Built-in `CustomMetric` that sums up metric values. Note that please extend
this class
+ * and override `name` and `description` to create your custom metric for real
usage.
*/
-class CustomSumMetric extends CustomMetric {
- override def name(): String = "CustomSumMetric"
-
- override def description(): String = "Sum up CustomMetric"
+abstract class CustomSumMetric extends CustomMetric {
Review comment:
I think we should move to v2 public package using Java.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/CustomMetrics.scala
##########
@@ -47,25 +47,21 @@ object CustomMetrics {
}
/**
- * Built-in `CustomMetric` that sums up metric values.
+ * Built-in `CustomMetric` that sums up metric values. Note that please extend
this class
+ * and override `name` and `description` to create your custom metric for real
usage.
*/
-class CustomSumMetric extends CustomMetric {
- override def name(): String = "CustomSumMetric"
-
- override def description(): String = "Sum up CustomMetric"
+abstract class CustomSumMetric extends CustomMetric {
Review comment:
I will create a followup to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
