zhengruifeng commented on a change in pull request #32328:
URL: https://github.com/apache/spark/pull/32328#discussion_r620046259
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##########
@@ -231,11 +231,12 @@ object EnsureRequirements extends Rule[SparkPlan] {
*/
private def reorderJoinPredicates(plan: SparkPlan): SparkPlan = {
plan match {
- case ShuffledHashJoinExec(leftKeys, rightKeys, joinType, buildSide,
condition, left, right) =>
+ case ShuffledHashJoinExec(
+ leftKeys, rightKeys, joinType, buildSide, condition, left, right,
isSkew) =>
val (reorderedLeftKeys, reorderedRightKeys) =
reorderJoinKeys(leftKeys, rightKeys, left.outputPartitioning,
right.outputPartitioning)
ShuffledHashJoinExec(reorderedLeftKeys, reorderedRightKeys, joinType,
buildSide, condition,
- left, right)
+ left, right, isSkew)
case SortMergeJoinExec(leftKeys, rightKeys, joinType, condition, left,
right, isPartial) =>
Review comment:
totally nit: what about renaming `isPartial` to `isSkew` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
