attilapiros commented on a change in pull request #32287:
URL: https://github.com/apache/spark/pull/32287#discussion_r620257493
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -613,6 +634,12 @@ final class ShuffleBlockFetcherIterator(
}
if (isNetworkReqDone) {
reqsInFlight -= 1
+ if (!buf.isInstanceOf[NettyManagedBuffer]) {
Review comment:
> Non-`NettyManagedBuffer` doesn't occupy Netty's memory
For me this means we do not necessary have some extra free off-heap memory
by this.
Could you please extend this comment with reasoning behind why the
`isNettyOOMOnShuffle` flag is set to `false` in this case?
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -613,6 +634,12 @@ final class ShuffleBlockFetcherIterator(
}
if (isNetworkReqDone) {
reqsInFlight -= 1
+ if (!buf.isInstanceOf[NettyManagedBuffer]) {
Review comment:
> Non-`NettyManagedBuffer` doesn't occupy Netty's memory
For me this means we do not necessary have some extra free off-heap memory
by this.
Could you please extend this comment with reasoning behind why the
`isNettyOOMOnShuffle` flag is set to `false` in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
