cloud-fan commented on a change in pull request #32082:
URL: https://github.com/apache/spark/pull/32082#discussion_r620444812
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/higherOrderFunctions.scala
##########
@@ -30,13 +30,14 @@ import org.apache.spark.sql.types.DataType
* so we need to resolve higher order function when all children are either
resolved or a lambda
* function.
*/
-case class ResolveHigherOrderFunctions(catalog: SessionCatalog) extends
Rule[LogicalPlan] {
+case class ResolveHigherOrderFunctions(catalogManager: CatalogManager)
+ extends Rule[LogicalPlan] with LookupCatalog {
override def apply(plan: LogicalPlan): LogicalPlan = plan.resolveExpressions
{
- case u @ UnresolvedFunction(fn, children, false, filter, ignoreNulls)
+ case u @ UnresolvedFunction(AsFunctionIdentifier(ident), children, false,
filter, ignoreNulls)
Review comment:
If the current catalog is a custom v2 catalog, and the function name has
only a single part, seems `AsFunctionIdentifier` always return None, while we
should treat it as a temp function first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
