allisonwang-db commented on a change in pull request #32303:
URL: https://github.com/apache/spark/pull/32303#discussion_r620567034
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1638,6 +1660,27 @@ class Analyzer(override val catalogManager:
CatalogManager)
}
}
+ /**
+ * Optionally resolve the name parts using the outer query plan and wrap
resolved attributes
+ * with [[OuterReference]]s.
+ */
+ private def resolveOuterReference(
Review comment:
Pulling up correlated conditions can be tricky. In this case, it works
because it's a simple equality condition, but for other cases such as having
correlated non-equality conditions below an aggregate, decorrelation becomes
more complex, and directly pulling up the filter conditions as join conditions
may yield incorrect results (SPARK-17348 and SPARK-35080).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
