ulysses-you commented on a change in pull request #32355:
URL: https://github.com/apache/spark/pull/32355#discussion_r620915076
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -139,6 +139,7 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
object JoinSelection extends Strategy
with PredicateHelper
with JoinSelectionHelper {
+ private val hintErrorHandler = conf.hintErrorHandler
Review comment:
I thought about it but seems we need to do this check in physical side.
We don't konw the join strategy at analysis or optimizer
(`EliminateResolvedHint`). For example, if user specify `boradcast`, we need to
check if it's a equijoin first then check the build side, since this join could
be bhj or bnlj.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
