ueshin commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r622435206
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
Review comment:
I don't think we should install them by default but should be extras.
##########
File path: dev/requirements.txt
##########
@@ -6,3 +6,13 @@ pydata_sphinx_theme
ipython
nbsphinx
numpydoc
+
+# dependencies in pandas-on-spark.
+pandas>=0.23.2
+pyarrow>=0.10
+numpy>=1.14,<1.20.0
+
+# Optional dependencies in pandas-on-spark.
+mlflow>=1.0
+plotly>=4.8
+matplotlib>=3.0.0,<3.3.0
Review comment:
What is this file used for?
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
- ]
+ ],
+ 'pandas.mlflow': ['mlflow>=1.0'],
+ 'pandas.plotly': ['plotly>=4.8'],
+ 'pandas.matplotlib': ['matplotlib>=3.0.0,<3.3.0'],
Review comment:
I'm not sure we should list these here? cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
