yijiacui-db commented on a change in pull request #31944:
URL: https://github.com/apache/spark/pull/31944#discussion_r622628591
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchStream.scala
##########
@@ -133,6 +137,10 @@ private[kafka010] class KafkaMicroBatchStream(
override def toString(): String = s"KafkaV2[$kafkaOffsetReader]"
+ override def metrics(latestOffset: Optional[Offset]): ju.Map[String, String]
= {
+ KafkaMicroBatchStream.metrics(latestOffset, latestPartitionOffsets)
Review comment:
Thanks for your suggestion! Yes, it's really really confusing. I've
changed the doc and param name.
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchStream.scala
##########
@@ -218,3 +226,35 @@ private[kafka010] class KafkaMicroBatchStream(
}
}
}
+
+object KafkaMicroBatchStream extends Logging {
+
+ /**
+ * Compute the difference of offset per partition between
latestAvailablePartitionOffsets
Review comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
