Yikun commented on a change in pull request #32386:
URL: https://github.com/apache/spark/pull/32386#discussion_r622692651
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
Review comment:
nit: pyarrow minimun version is introduced in _minimum_pyarrow_version,
but if we introduce the `pyarrow>=0.10` for pandas_on_spark in here, maybe we
could change the `_minimum_pyarrow_version` to something like
`_minimum_sql_pyarrow_version`
[1]
https://github.com/apache/spark/pull/32386/files#diff-eb8b42d9346d0a5d371facf21a8bfa2d16fb49e213ae7c21f03863accebe0fcfR115
##########
File path: python/setup.py
##########
@@ -250,14 +257,22 @@ def run(self):
license='http://www.apache.org/licenses/LICENSE-2.0',
# Don't forget to update python/docs/source/getting_started/install.rst
# if you're updating the versions or dependencies.
- install_requires=['py4j==0.10.9.2'],
+ install_requires=[
+ 'py4j==0.10.9.2',
+ 'pandas>=0.23.2',
+ 'pyarrow>=0.10',
+ 'numpy>=1.14,<1.20.0',
+ ],
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': [
'pandas>=%s' % _minimum_pandas_version,
'pyarrow>=%s' % _minimum_pyarrow_version,
- ]
+ ],
+ 'pandas.mlflow': ['mlflow>=1.0'],
+ 'pandas.plotly': ['plotly>=4.8'],
+ 'pandas.matplotlib': ['matplotlib>=3.0.0,<3.3.0'],
Review comment:
We might need to add some description in [1] to add the dependencies
info for pandas_on_spark.
[1]
https://spark.apache.org/docs/latest/api/python/getting_started/install.html#dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
