AngersZhuuuu commented on a change in pull request #32266:
URL: https://github.com/apache/spark/pull/32266#discussion_r623553192
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -92,6 +93,25 @@ object IntervalUtils {
}
private val yearMonthPattern = "^([+|-])?(\\d+)-(\\d+)$".r
+ private val yearMonthStringPattern =
+
"^(INTERVAL\\s+)([+|-])?(')([+|-])?(\\d+)-(\\d+)(')(\\s+YEAR\\s+TO\\s+MONTH)$".r
+
+ def castStringToYMInterval(input: UTF8String): Int = {
+ input.trimAll().toString.toUpperCase(Locale.ROOT) match {
Review comment:
> You don't see any tests that check proper spaces handling - I mean
`trimAll()`. Could you add such checks.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]