cloud-fan commented on a change in pull request #32361:
URL: https://github.com/apache/spark/pull/32361#discussion_r623568983
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CheckpointFileManager.scala
##########
@@ -285,6 +291,11 @@ class FileSystemBasedCheckpointFileManager(path: Path,
hadoopConf: Configuration
case _: LocalFileSystem | _: RawLocalFileSystem => true
case _ => false
}
+
+ override def createCheckpointDirectory(): Path = {
+ fs.mkdirs(path, FsPermission.getDirDefault)
+ fs.makeQualified(path)
Review comment:
shall we qualify first before calling `mkdirs`? Or it doesn't matter?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CheckpointFileManager.scala
##########
@@ -351,6 +362,11 @@ class FileContextBasedCheckpointFileManager(path: Path,
hadoopConf: Configuratio
case _ => false
}
+ override def createCheckpointDirectory(): Path = {
+ fc.mkdir(path, FsPermission.getDirDefault, true)
+ fc.makeQualified(path)
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
