cloud-fan commented on a change in pull request #32391:
URL: https://github.com/apache/spark/pull/32391#discussion_r623610625
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
##########
@@ -278,7 +278,8 @@ trait JoinSelectionHelper {
* Matches a plan whose output should be small enough to be used in
broadcast join.
*/
def canBroadcastBySize(plan: LogicalPlan, conf: SQLConf): Boolean = {
- plan.stats.sizeInBytes >= 0 && plan.stats.sizeInBytes <=
conf.autoBroadcastJoinThreshold
+ plan.stats.sizeInBytes >= 0 &&
+ plan.stats.sizeInBytes <=
autoBroadcastJoinThreshold(plan.stats.isRuntime, conf)
Review comment:
We don't need the method now, just put if-else here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
