viirya commented on a change in pull request #32404:
URL: https://github.com/apache/spark/pull/32404#discussion_r623642201
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -325,11 +325,11 @@ case class Invoke(
@transient lazy val method = targetObject.dataType match {
case ObjectType(cls) =>
- val m = cls.getMethods.find(_.getName == encodedFunctionName)
- if (m.isEmpty) {
- sys.error(s"Couldn't find $encodedFunctionName on $cls")
- } else {
- m
+ try {
Review comment:
There is a bit difference between two `method` from `Invoke` and
`StaticInvoke`. For example, `StaticInvoke` doesn't use encoded function name.
Is it safe to share `method` between them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
