Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5798#discussion_r29406469
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveResolutionSuite.scala
 ---
    @@ -81,9 +81,13 @@ class HiveResolutionSuite extends HiveComparisonTest {
           .toDF().registerTempTable("caseSensitivityTest")
     
         val query = sql("SELECT a, b, A, B, n.a, n.b, n.A, n.B FROM 
caseSensitivityTest")
    -    assert(query.schema.fields.map(_.name) === Seq("a", "b", "A", "B", 
"a", "b", "A", "B"),
    +    assert(query.schema.fields.map(_.name) === Seq("a", "b", "a", "b", 
"a", "b", "a", "b"),
           "The output schema did not preserve the case of the query.")
    --- End diff --
    
    Supporting normalization is good. However, when explicitly specifying the 
case in the query, should we need to preserve the case of the query, instead of 
normalizing it like this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to