viirya commented on a change in pull request #32404:
URL: https://github.com/apache/spark/pull/32404#discussion_r624432958
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -325,11 +325,30 @@ case class Invoke(
@transient lazy val method = targetObject.dataType match {
case ObjectType(cls) =>
- val m = cls.getMethods.find(_.getName == encodedFunctionName)
- if (m.isEmpty) {
- sys.error(s"Couldn't find $encodedFunctionName on $cls")
- } else {
- m
+ // Looking with function name + argument classes first.
+ try {
+ Some(cls.getMethod(encodedFunctionName, argClasses: _*))
+ } catch {
+ case _: NoSuchMethodException =>
+ // For some cases, e.g. arg class is Object, `getMethod` cannot find
the method.
+ // We look at function name + argument length
+ val m = cls.getMethods.filter { m =>
+ m.getName == encodedFunctionName && m.getParameterCount ==
arguments.length
+ }
+ if (m.isEmpty) {
+ sys.error(s"Couldn't find $encodedFunctionName on $cls")
+ } else if (m.length > 1) {
+ // More than one matched method signature. Exclude synthetic one,
e.g. generic one.
+ val realMethods = m.filter(!_.isSynthetic)
Review comment:
I don't know if it is possible that there is only one method and it is
also a synthetic one. If we filter synthetic ones at L336, we may miss it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
