viirya commented on a change in pull request #32413:
URL: https://github.com/apache/spark/pull/32413#discussion_r624858933
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
##########
@@ -638,8 +638,22 @@ class ObjectExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
val clsType = ObjectType(classOf[ConcreteClass])
val obj = new ConcreteClass
+ val input = (1, 2)
checkObjectExprEvaluation(
- Invoke(Literal(obj, clsType), "testFunc", IntegerType, Seq(Literal(1))),
0)
+ Invoke(Literal(obj, clsType), "testFunc", IntegerType,
+ Seq(Literal(input, ObjectType(input.getClass)))), 2)
Review comment:
Fix this test from SPARK-35278. Original one doesn't produce synthetic
method. I may miss it when I changed the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
